Repository navigation
StandardApp: add selectable: false to leave out the SelectionArea - #145
Merged
Merged
Conversation
Code Coverage Report - 120 of 354 lines covered ( ⛔ 33.90%)
|
bigsamich
requested review from
mguzman04 and
rneswold
and
a balanced review from Copilot
October 1, 2026 18:38
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The backward-compatible implementation is focused, documented, and adequately tested.
Review effort: Balanced
Findings: None
What changed in this PR
Adds an opt-out for StandardApp text selection to reduce overhead for frequently updating text while preserving existing behavior by default.
Changes:
- Adds the
selectableparameter, defaulting totrue. - Conditionally omits
SelectionArea. - Tests both default and disabled behavior.
| File | Description |
|---|---|
lib/src/app_scaffold.dart |
Adds and applies the selectable option. |
test/widget/app_scaffold_test.dart |
Verifies selection wrapping behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Code Coverage Report - 120 of 354 lines covered ( ⛔ 33.90%)
|
Contributor
|
The intent of having Perhaps it's best to remove it entirely and have individual apps handle text selection? |
Contributor
|
I did not know that |
Contributor
Author
|
Thats a question for the app devs. Ill put john and dono on this as well |
Contributor
|
I agree - this should be false by default but we should nudge developers to set it to |
Selecting the entire app has an impact on performance. We shut it off, by default. A developer can choose to enable it for their app.
Updated tests to reflect changes in SelectionArea behavior based on selectable property.
Code Coverage Report - 120 of 354 lines covered ( ⛔ 33.90%)
|
Bump version number so dependents can use SemVer to update.
Code Coverage Report - 120 of 354 lines covered ( ⛔ 33.90%)
|
Update the docs to use the SemVer-compatible syntax in `pubspec.yaml`.
Code Coverage Report - 120 of 354 lines covered ( ⛔ 33.90%)
|
rneswold
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
StandardAppalways wraps the app in aSelectionArea, so everyTextregisters as selectable. In apps whose text changes many times a second (live readings), that is extra work on every change. After a click it can also throw (on Linux: "Concurrent modification during iteration" in_ScrollableSelectionContainerDelegate.handleClearSelection, seen in bpm-hub).Change: a
selectableparameter, defaulttrue(no change for existing apps).selectable: falseleaves theSelectionAreaout.Tests: two new widget tests (default has the
SelectionArea,falsedoesn't);flutter analyzeclean,flutter test16 passed.